Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118

From: Kurt Borja

Date: Fri Nov 28 2025 - 12:40:09 EST


On Fri Nov 28, 2025 at 4:43 AM -05, Krzysztof Kozlowski wrote:
> On 28/11/2025 04:37, Kurt Borja wrote:
>> +
>> + interrupts:
>> + description: DOUT/DRDY (Data Out/Data Ready) line.
>> + maxItems: 1
>> +
>> + drdy-gpios:
>> + description:
>> + Extra GPIO line connected to DOUT/DRDY (Data Out/Data Ready). This allows
>> + distinguishing between interrupts triggered by the data-ready signal and
>> + interrupts triggered by an SPI transfer.
>> + maxItems: 1
>> +
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>
> These two properties are not correct now - you do not have any children.
>
>> +
>> + '#io-channel-cells':
>> + const: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - vdd-supply
>> + - '#address-cells'
>> + - '#size-cells'
>
> And they should not be required.

I'll drop these. Thank you, Krzysztof!

>
>
> Best regards,
> Krzysztof


--
~ Kurt