Re: [PATCH v5 17/27] iommu/arm-smmu-v3-kvm: Probe SMMU HW

From: Jason Gunthorpe

Date: Fri Nov 28 2025 - 12:07:50 EST


On Mon, Nov 17, 2025 at 06:48:04PM +0000, Mostafa Saleh wrote:

> +/*
> + * Mini-probe and validation for the hypervisor.
> + */
> +static int smmu_probe(struct hyp_arm_smmu_v3_device *smmu)
> +{
> + u32 reg;
> +
> + /* IDR0 */
> + reg = readl_relaxed(smmu->base + ARM_SMMU_IDR0);
> + smmu->features = smmu_idr0_features(reg);
> +
> + /*
> + * Some MMU600 and MMU700 have errata that prevent them from using nesting,
> + * not sure how can we identify those, so it's recommended not to enable this
> + * drivers on such systems.
> + * And preventing any of those will be too restrictive
> + */

This driver is doing nesting though ??

Shouldn't you detect those IPs and not support a S1 at all so there is
no nesting? Identity only?

Jason