RE: [PATCH 17/19] arm64: dts: renesas: r9a09g047: Add RSCI nodes

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 28 November 2025 13:05
> Subject: Re: [PATCH 17/19] arm64: dts: renesas: r9a09g047: Add RSCI nodes
> 
> Hi Biju,
> 
> On Mon, 27 Oct 2025 at 16:47, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Add RSCI nodes to RZ/G3E ("R9A09G047") SoC DTSI.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > @@ -823,6 +823,196 @@ i2c8: i2c@11c01000 {
> >                         status = "disabled";
> >                 };
> >
> > +               rsci0: serial@12800c00 {
> > +                       compatible = "renesas,r9a09g047-rscif";
> 
> "renesas,r9a09g047-rsci", as per the updated DT bindings.

OK.

> 
> > +                       reg = <0 0x12800c00 0 0x400>;
> > +                       interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 115 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 116 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> > +                       interrupt-names = "eri", "rxi", "txi", "tei";
> 
> Missing "aed" and "bfd" interrupts, as per to-be-updated DT bindings.

OK.

> 
> > +                       clocks = <&cpg CPG_MOD 93>, <&cpg CPG_MOD 94>,
> > +                                <&cpg CPG_MOD 95>, <&cpg CPG_MOD 96>,
> > +                                <&cpg CPG_MOD 97>;
> > +                       clock-names = "bus", "tclk", "tclk_div64",
> > +                                     "tclk_div16", "tclk_div4";
> 
> Third and fifth clock and clock name should be exchanged, as per the updated DT bindings.

OK.
> 
> > +                       power-domains = <&cpg>;
> > +                       resets = <&cpg 129>, <&cpg 130>;
> 
> Please use hexadecimal numbers for module clocks and resets, for easier matching with the
> documentation.

Agreed, Will fix this in next version.

Cheers,
Biju