Re: [PATCH] sched/fair: Force idle aware load balancing

From: Peter Zijlstra

Date: Fri Nov 28 2025 - 06:14:36 EST


On Thu, Nov 27, 2025 at 10:27:17PM +0200, Fernand Sieber wrote:

> @@ -11123,7 +11136,8 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s
> return;
> }
>
> - if (busiest->group_type == group_smt_balance) {
> + if (busiest->group_type == group_smt_balance ||
> + busiest->forceidle_weight) {

Should we not instead make it so that we select group_smt_balance in
this case?

Anyway, the patch doesn't seem horrible to me. Vincent?

> /* Reduce number of tasks sharing CPU capacity */
> env->migration_type = migrate_task;
> env->imbalance = 1;