Re: [PATCH net-next V4 08/14] devlink: Allow rate node parents from other devlinks
From: Cosmin Ratiu
Date: Fri Nov 28 2025 - 04:57:11 EST
On Thu, 2025-11-27 at 20:09 -0800, Jakub Kicinski wrote:
> On Tue, 25 Nov 2025 22:06:07 +0200 Tariq Toukan wrote:
> > @@ -646,6 +706,13 @@ int devlink_nl_rate_set_doit(struct sk_buff
> > *skb, struct genl_info *info)
> > goto unlock;
> > }
> >
> > + if (info->user_ptr[1] && info->user_ptr[1] != devlink &&
> > + !ops->supported_cross_device_rate_nodes) {
> > + NL_SET_ERR_MSG(info->extack,
> > + "Cross-device rate parents aren't
> > supported");
> > + return -EOPNOTSUPP;
>
> err = ...
> goto unlock
Nice catch. Will fix.
Cosmin.