RE: [PATCH iwl-next v2 5/8] ice: update mac,vlan rules when toggling between VEB and VEPA

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Slepecki, Jakub <jakub.slepecki@xxxxxxxxx>
> Sent: Friday, November 28, 2025 9:29 AM
> To: Loktionov, Aleksandr <aleksandr.loktionov@xxxxxxxxx>; intel-wired-
> lan@xxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Kitszel,
> Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; michal.swiatkowski@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH iwl-next v2 5/8] ice: update mac,vlan rules when
> toggling between VEB and VEPA
> 
> On 2025-11-25 9:52, Loktionov, Aleksandr wrote:
> > Better to provide exact bash commands.
> 
> All right, I'll review the commands in the 0/8 and see if I can expand them
> for this context.  I'll refer it here.  I suppose I could add the
> bridge(8) example for hwmode?  Something like:
> 
>      Testing hints:
>          MAC,VLAN rules are created only if entire series is applied.
>          The easiest way to test that rules were adjusted is to run traffic
>          and observe what packets are sent to LAN.  VEPA is expected to
> behave
>          same as before the series.  VEB is expected to (a) behave like VEPA
>          if loopback traffic would cross VLANs, or (b) behave as before.
>          Traffic from/to external hosts is expected to remain unchanged.
> 
>          Refer to 0/8 for full network configuration.  To change hwmode use:
> 
>          bridge link set dev $pf hwmode {veb,vepa}
> 
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
> 
> I'll drop it since you did not explicitly say it's fine to keep it.
> 
> Thanks!

Thanks for clarifying and for adding the testing hints.

The example with `bridge link set dev $pf hwmode {veb,vepa}` looks good and makes the intent clear. Adding the note that MAC/VLAN rules require the full series is helpful.

One small suggestion: please include prerequisites in the 0/8 cover letter (e.g., `iproute2` version and that commands need root privileges), so testers don’t miss that.

Otherwise, the instructions are fine from my side. Please keep my:

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>

Thanks!