Re: [PATCH] MEDIATEK: serial: 8250_mtk: Add ACPI support

[Greg Kroah-Hartman]

On Fri, Nov 28, 2025 at 10:17:56AM +0800, zhiyong.tao wrote:
> From: "Zhiyong.Tao" <zhiyong.tao@xxxxxxxxxxxx>

Please use your name, not your email alias (i.e. drop the "." from the
name portion.)

> Add ACPI support to 8250_mtk driver. This makes it possible to
> use UART on ARM-based desktops with EDK2 UEFI firmware.
> 
> Signed-off-by: Yenchia Chen <yenchia.chen@xxxxxxxxxxxx>
> Signed-off-by: Zhiyong.Tao <zhiyong.tao@xxxxxxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250_mtk.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index 5875a7b9b4b1..e6a56cf54ae0 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -19,6 +19,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/tty.h>
>  #include <linux/tty_flip.h>
> +#include <linux/units.h>

Do you also need to update the Kconfig dependencies?

thanks,

greg k-h