Re: [PATCH] f2fs: fix to check bio after __blkdev_issue_discard()
From: Chao Yu
Date: Thu Nov 27 2025 - 22:34:29 EST
On 11/26/25 14:41, Christoph Hellwig wrote:
> It can only return blk_alloc_discard_bio if the the gfp_mask doesn't
> allow sleeping (which isn't the case here), or nr_sect is zero,
> which I hope is also not the case as __submit_discard_cmd would
> run into various other problems. So no, I don't think this is
> patch makes any sense.
Oh, I checked details in bio_alloc_bioset() again, it seems I missed
something for mempool_alloc(), as you mentioned, it may only fail due
to caller is in non-sleep context passing gfp w/ GFP_ATOMIC or
GFP_NOWAIT, which is not the case for f2fs discard.
Thanks,