Re: [v3, net-next 10/12] bng_en: Add initial support for ethtool stats display

From: Jakub Kicinski

Date: Thu Nov 27 2025 - 22:13:37 EST


On Thu, 27 Nov 2025 01:19:29 +0530 Bhargava Marreddy wrote:
> +static const char * const bnge_ring_rx_stats_str[] = {
> + "rx_ucast_packets",
> + "rx_mcast_packets",
> + "rx_bcast_packets",
> + "rx_discards",
> + "rx_errors",
> + "rx_ucast_bytes",
> + "rx_mcast_bytes",
> + "rx_bcast_bytes",
> +};
> +
> +static const char * const bnge_ring_tx_stats_str[] = {
> + "tx_ucast_packets",
> + "tx_mcast_packets",
> + "tx_bcast_packets",
> + "tx_errors",
> + "tx_discards",
> + "tx_ucast_bytes",
> + "tx_mcast_bytes",
> + "tx_bcast_bytes",
> +};
> +
> +static const char * const bnge_ring_tpa_stats_str[] = {
> + "tpa_packets",
> + "tpa_bytes",
> + "tpa_events",
> + "tpa_aborts",
> +};
> +
> +static const char * const bnge_ring_tpa2_stats_str[] = {
> + "rx_tpa_eligible_pkt",
> + "rx_tpa_eligible_bytes",
> + "rx_tpa_pkt",
> + "rx_tpa_bytes",
> + "rx_tpa_errors",
> + "rx_tpa_events",
> +};
> +
> +static const char * const bnge_rx_sw_stats_str[] = {
> + "rx_l4_csum_errors",
> + "rx_resets",
> + "rx_buf_errors",
> +};

We do not allow duplicating standard stats in ethtool -S any more.