Re: [PATCH v2] perf tools: Don't read build-ids from non-regular files

[Namhyung Kim]

On Mon, 24 Nov 2025 10:59:08 +0000, James Clark wrote:
> Simplify the build ID reading code by removing the non-blocking option.
> Having to pass the correct option to this function was fragile and a
> mistake would result in a hang, see the linked fix. Furthermore,
> compressed files are always opened blocking anyway, ignoring the
> non-blocking option.
> 
> We also don't expect to read build IDs from non-regular files. The only
> hits to this function that are non-regular are devices that won't be elf
> files with build IDs, for example "/dev/dri/renderD129".
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung