Re: [PATCH net-next v8 1/1] Documentation: net: add flow control guide and document ethtool API

[Russell King (Oracle)]

On Thu, Nov 27, 2025 at 04:48:42PM +0100, Andrew Lunn wrote:
> Maybe for the last year, when i have seen broken pause, i've been
> reporting the problems but also pushing developers towards
> phylink. phylink also does all the business logic for EEE, and is
> starting to get WoL support.

Not "starting" - it has a full implementation for it, unless I'm
missing something.

What is missing is the upgrade of phylib drivers to a more modern WoL
approach where they actually tell us that they truly are capable of
waking the system - I don't think that's something we has core code
maintainers can really get involved with, but push people to do the
necessary leg work to make it so.

We have far too many phylib drivers that implement the get_wol
without a thought to whether the hardware can actually wake the
system, and that is completely incompatible with having logic to
determine whether a certain WoL configuration should be set on the
PHY or the MAC.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!