Re: [PATCH v2 5/6] spi: microchip-core: Use SPI_MODE_X_MASK

[Prajna Rajendra Kumar]

On 26/11/2025 07:54, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Prajna Rajendra Kumar <prajna.rajendrakumar@xxxxxxxxxxxxx>
> ---
>   drivers/spi/spi-microchip-core-spi.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-microchip-core-spi.c b/drivers/spi/spi-microchip-core-spi.c
> index 0dca46dcdc2f..941b7e23eac3 100644
> --- a/drivers/spi/spi-microchip-core-spi.c
> +++ b/drivers/spi/spi-microchip-core-spi.c
> @@ -148,8 +148,6 @@ static void mchp_corespi_set_cs(struct spi_device *spi, bool disable)
>
>   static int mchp_corespi_setup(struct spi_device *spi)
>   {
> -       u32 dev_mode = spi->mode & (SPI_CPOL | SPI_CPHA);
> -
>          if (spi_get_csgpiod(spi, 0))
>                  return 0;
>
> @@ -158,7 +156,7 @@ static int mchp_corespi_setup(struct spi_device *spi)
>                  return -EOPNOTSUPP;
>          }
>
> -       if (dev_mode & ~spi->controller->mode_bits) {
> +       if (spi->mode & SPI_MODE_X_MASK & ~spi->controller->mode_bits) {
>                  dev_err(&spi->dev, "incompatible CPOL/CPHA, must match controller's Motorola mode\n");
>                  return -EINVAL;
>          }
> --
> 2.50.1