Re: [PATCH] mailbox: pcc: don't zero error register

[Sudeep Holla]

On Wed, Nov 05, 2025 at 02:42:29PM +0000, Punit Agrawal wrote:
> From: Jamie Iles <jamie.iles@xxxxxxxxxxxxxxxx>
> 
> The error status mask for a type 3/4 subspace is used for reading the
> error status, and the bitwise inverse is used for clearing the error
> with the intent being to preserve any of the non-error bits.  However,
> we were previously applying the mask to extract the status and then
> applying the inverse to the result which ended up clearing all bits.
> 
> Instead, store the inverse mask in the preserve mask and then use that
> on the original value read from the error status so that only the error
> is cleared.
> 
> Fixes: c45ded7e1135 ("mailbox: pcc: Add support for PCCT extended PCC subspaces(type 3/4)")

Good catch!

Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx>

-- 
Regards,
Sudeep