Re: [PATCH 1/2] mcb: Add missing modpost build support

[Jose Javier Rodriguez Barbarin]

On Fri, Nov 28, 2025 at 11:02:57AM +0200, Andy Shevchenko wrote:
> On Fri, Nov 28, 2025 at 08:54:18AM +0100, Jiri Slaby wrote:
> > On 27. 11. 25, 17:10, Andy Shevchenko wrote:
> 
> ...
> 
> > > >   static const struct devtable devtable[] = {
> > > 
> > > >          {"cpu", SIZE_cpu_feature, do_cpu_entry},
> > > >          {"mei", SIZE_mei_cl_device_id, do_mei_entry},
> > > >          {"rapidio", SIZE_rio_device_id, do_rio_entry},
> > > > +       {"mcb", SIZE_mcb_device_id, do_mcb_entry},
> > > 
> > > Perhaps squeeze it to be more ordered (yes, I know that the table is
> > > not so ordered, but given context suggests to put it after "mei").

Thanks your answers,

I put it between "rapidio" and "ulpi" because mcb_device_id is defined in
mod_devicetable.h between rio_device_id and ulpi_device_id so I though it
could be nice to follow the same order on file2alias.c.

> > 
> > s/after/before/ :)
> 
> Right, good catch!
> 

It is OK to me, I will put it before mei ;)

> -- 
> With Best Regards,
> Andy Shevchenko
> 
>