Re: [PATCH v4] most: core: fix resource leak in most_register_interface error paths

[Dan Carpenter]

On Thu, Nov 27, 2025 at 04:53:37PM +0000, Navaneeth K wrote:
> The function most_register_interface() did not correctly release resources
> if it failed early (before registering the device). In these cases, it
> returned an error code immediately, leaking the memory allocated for the
> interface.
> 
> Fix this by initializing the device early via device_initialize() and
> calling put_device() on all error paths.
> 
> The most_register_interface() is expected to call put_device() on
> error which frees the resources allocated in the caller. The
> put_device() either calls release_mdev() or dim2_release(),
> depending on the caller.
> 
> Switch to using device_add() instead of device_register() to handle
> the split initialization.
> 
> Acked-by: Abdun Nihaal <abdun.nihaal@xxxxxxxxx>
> Signed-off-by: Navaneeth K <knavaneeth786@xxxxxxxxx>
> ---

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter