Re: [PATCH] selftests: mptcp: initialize raw_addr to Null
From: Jakub Kicinski
Date: Fri Nov 28 2025 - 13:40:58 EST
On Fri, 28 Nov 2025 11:34:38 +0100 Matthieu Baerts wrote:
> > Including kselftest.h will be needed.
>
> Because mptcp_connect.c is a tool that is used by other selftests, but
> it doesn't interact directly with the selftests, maybe we don't need to
> include it, and only add this #define in mptcp_connect.c?
>
> #define __noreturn __attribute__((__noreturn__))
Up to you, I'd be worried that some semi-automated patch generator will
send us a "cleanup" to remove this as duplication. But I'm overly
sensitive to this sort of followups so we can try if you prefer :)