Re: [PATCH 1/6] ASoC: codecs: wsa884x: remove mute_unmute_on_trigger

[Jonathan Marek]

On 11/27/25 5:14 AM, Srinivas Kandagatla wrote:

> Interesting, I guess this is not an upstream driver. The change and log
> itself does not make any sense on upstream. pl correct me otherwise.

> That is true, The issue that enable stream happens at machine driver
> prepare and disable happens in hw_params_free.
> We have window of opportunity for click and pop between the mute and
> enable and in reverse direction.
>
> Am not sure this patch is improving or fixing anything on this side.

This patch isn't improving or fixing anything (at least upstream),
its removing a hidden (and unnecessary) nonatomic dependency. It 
shouldn't change anything with the pop/click situation. Without 
mute_unmute_on_trigger the mute/unmute still happens inside that "window 
of opportunity".

My driver is not upstream but it could be, and I need atomic trigger. 
You can imagine that I am using the lpass-cpu driver (which is similar 
and upstream), which also does not want nonatomic trigger.

note:
- the common qcom sndcard parsing only sets nonatomic if a "platform" is 
set, which the lpass-cpu dts don't have
- none of the upstream dts that use lpass-cpu use wsa884x/wsa883x, but 
its possible to use these parts with sc7280
- upstream sc7280 uses wcd9385, so using mute_unmute_on_trigger in that 
driver would break upstream sc7280 audio

> Also I noticed during testing on T14s one of the speakers (left) went
> into mute, not sure if this is something which is an existing issue but
> reverting the patch made it work again.. Need more testing and debugging
> to understand what could be going wrong.

This workaround might be relevant:

https://github.com/flto/linux/commit/83b6c10d7c6248b9633a1516b816f211607d4eca