Re: [PATCH 1/3] Corrected errno in minix_new_inode

[Jan Kara]

On Tue 25-11-25 22:34:28, Jori Koolstra wrote:
> 
> > 
> > OK, but this will make the compiler likely unhappy (because it doesn't know
> > s_imap_blocks cannot be 0) and generally the code will be less
> > self-containted. So in the spirit of defensive programming I'd leave the
> > assignment there.
> > 
> 
> OK, I see. I agree. Still should it then not be set where j is declared?

Could be but I don't think changing this is really worth the churn.

> But that is a very minor point. I am okay with removing that change.

While it is good to trim unnecessary context it is also good to leave in
the email the patch hunk we are speaking about because frankly I already
forgot the details and now have to go to lore to check old emails in this
thread to remind myself.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR