Re: [PATCH 1/3] dt-bindings: mtd: cdns,hp-nfc: Add dma-coherent property
From: Krzysztof Kozlowski
Date: Thu Nov 27 2025 - 02:48:08 EST
On Wed, Nov 26, 2025 at 04:06:22PM +0800, Khairul Anuar Romli wrote:
> The Cadence HP NAND Flash Controller on Agilex5 device performs DMA
> transactions through a coherent interconnect. dma-coherent property
> presents in device tree will allow the kernel’s DMA subsystem
> controller’s to performs DMA transaction in dma coherent mode.
Last sentence is redundant. You say basically "dma-coherent means
dma coherent". Write informative commit msgs, so something which is not
obvious, e.g. why this is dma coherent NOW but wasn't before?
Best regards,
Krzysztof