Re: [PATCH 1/2] gpio: shared: ignore special __symbols__ node when traversing device tree

[Jon Hunter]

On 26/11/2025 16:49, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> The __symbols__ node is a special, internal node and its properties must
> not be considered when scanning the device-tree for shared GPIOs.
>
> Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")
> Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/0829a21c-f97d-41b6-90bc-2acaec42caab@xxxxxxxxxx/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
>   drivers/gpio/gpiolib-shared.c | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
> index 3803b5c938f9933dab01c6d777c349ed3b42ce9b..62f32489a8a6f70c567ed93645f1e36a81612def 100644
> --- a/drivers/gpio/gpiolib-shared.c
> +++ b/drivers/gpio/gpiolib-shared.c
> @@ -73,6 +73,19 @@ gpio_shared_find_entry(struct fwnode_handle *controller_node,
>   	return NULL;
>   }
>   
> +/* Handle all special nodes that we should ignore. */
> +static bool gpio_shared_of_node_ignore(struct device_node *node)
> +{
> +	/*
> +	 * __symbols__ is a special, internal node and should not be considered
> +	 * when scanning for shared GPIOs.
> +	 */
> +	if (of_node_name_eq(node, "__symbols__"))
> +		return true;
> +
> +	return false;
> +}
> +
>   static int gpio_shared_of_traverse(struct device_node *curr)
>   {
>   	struct gpio_shared_entry *entry;
> @@ -84,6 +97,9 @@ static int gpio_shared_of_traverse(struct device_node *curr)
>   	const char *suffix;
>   	int ret, count, i;
>   
> +	if (gpio_shared_of_node_ignore(curr))
> +		return 0;
> +
>   	for_each_property_of_node(curr, prop) {
>   		/*
>   		 * The standard name for a GPIO property is "foo-gpios"

Fixes it for me!

Tested-by: Jon Hunter <jonathanh@xxxxxxxxxx>
Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks
Jon

--
nvpublic