Re: [PATCH v2] iio: isl29018.c: replace sprintf with safer alternatives

[Andy Shevchenko]

On Wed, Nov 26, 2025 at 02:24:32PM -0300, Tomas Borquez wrote:
> This patch replaces sprintf with sysfs_emit and sysfs_emit_at safer alternative

sprintf()
"...sysfs_emit() and sysfs_emit_at()..."

alternatives

OR

"...sysfs_emit() or sysfs_emit_at()..."

> with no functional changes.

...

> -		len += sprintf(buf + len, "%d.%06d ",
> +		len += sysfs_emit_at(buf, len, "%d.%06d ",
>  			       isl29018_scales[chip->int_time][i].scale,
>  			       isl29018_scales[chip->int_time][i].uscale);

Forgot to update indentation.

...

>  	for (i = 0; i < ARRAY_SIZE(isl29018_int_utimes[chip->type]); ++i)
> -		len += sprintf(buf + len, "0.%06d ",
> +		len += sysfs_emit_at(buf, len, "0.%06d ",
>  			       isl29018_int_utimes[chip->type][i]);

Ditto.

-- 
With Best Regards,
Andy Shevchenko