Re: [PATCH bpf-next v1 4/4] resolve_btfids: change in-place update with raw binary output

[Ihor Solodrai]

On 11/26/25 5:03 AM, Donglin Peng wrote:
> On Wed, Nov 26, 2025 at 9:29 AM Ihor Solodrai <ihor.solodrai@xxxxxxxxx> wrote:
>>
>> [...]
>>
>> For the kernel modules creating special .bpf.o file is not necessary,
>> and so embedding of sections data produced by resolve_btfids is
>> straightforward with the objcopy.
> 
> The Makefile for the bpf selftests also needs be updated too:
> https://elixir.bootlin.com/linux/v6.18-rc7/source/tools/testing/selftests/bpf/Makefile#L708
> 
> This results in the self-test for resolve_btfids failing:
>  $./vmtest.sh -- ./test_progs -t resolve_btfids -v
> ...
> test_resolve_btfids:PASS:id_check 0 nsec
> test_resolve_btfids:FAIL:id_check wrong ID for S (0 != 3)

Good catch, thanks.

I remember I noticed this at some point, and then forgot...

Interestingly this test passes on CI [1]: 

2025-11-26T03:09:52.0908317Z #366     reg_bounds_rand_ranges_u64_u64:OK
2025-11-26T03:09:52.0925114Z #367     resolve_btfids:OK
2025-11-26T03:09:52.3904190Z #368/1   res_spin_lock_failure/res_spin_lock_arg:OK

I'll take a closer look.

[1] https://github.com/kernel-patches/bpf/actions/runs/19690981192/job/56406840021

> 
> 
>> [...]
>>