Re: [PATCH v2 1/2] rv: Convert to use lock guard

From: Steven Rostedt

Date: Wed Nov 26 2025 - 10:41:27 EST


On Wed, 26 Nov 2025 10:33:51 +0100
Gabriele Monaco <gmonaco@xxxxxxxxxx> wrote:

> > > No biggy, but I wonder if this would look better as:
> > >
> > > return retval ? : count;
> >
> > Unless you really prefer it this way, I would rather not. The first time
> > I saw this syntax, it confused the hell out of me. Took me some time
> > scratching my head until I figured out that it is a GNU extension.
> >
> > I prefer to stay with the C standard unless there is major benefit not
> > to.
>
> To be fair, I find it a bit obscure as well, although it's frequently used
> within the kernel.
>
> Let's not change it then.

As I said, "No biggy". I personally like that notation better. But that's
my own personal choice. I won't push that on other ;-)

-- Steve