Re: [PATCH] can: rcar_canfd: Fix CAN-FD mode as default

From: Marc Kleine-Budde

Date: Wed Nov 26 2025 - 10:27:43 EST


On 18.11.2025 12:39:25, Biju wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> The commit 5cff263606a1 ("can: rcar_canfd: Fix controller mode setting")
> has aligned with the flow mentioned in the hardware manual for all SoCs
> except R-Car Gen3 and RZ/G2L SoCs. On R-Car Gen4 and RZ/G3E SoCs, due to
> the wrong logic in the commit[1] sets the default mode to FD-Only mode
> instead of CAN-FD mode.
>
> This patch sets the CAN-FD mode as the default for all SoCs by dropping
> the rcar_canfd_set_mode() as some SoC requires mode setting in global
> reset mode, and the rest of the SoCs in channel reset mode and update the
> rcar_canfd_reset_controller() to take care of these constraints. Moreover,
> the RZ/G3E and R-Car Gen4 SoCs support 3 modes compared to 2 modes on the
> R-Car Gen3. Use inverted logic in rcar_canfd_reset_controller() to
> simplify the code later to support FD-only mode.

Applied to linux-can

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature