Re: [PATCH v2 2/6] spi: microchip-core: Refactor FIFO read and write handlers

From: Mark Brown

Date: Wed Nov 26 2025 - 07:05:26 EST


On Wed, Nov 26, 2025 at 09:21:45AM +0000, david laight wrote:

> I'm not sure I don't prefer the version with one writeb() call.
> How about:
> writeb(spi->tx_buf ? *spi->tx_buf++ : 0xaa,
> spi->regs + MCHP_CORESPI_REG_TXDATA);

Please don't abuse the ternery operator like this, just write normal
conditional statements.

Attachment: signature.asc
Description: PGP signature