Re: [PATCH v3 0/1] platform/x86: serial-multi-instantiate: ACPI example code

From: Andy Shevchenko

Date: Wed Nov 26 2025 - 06:43:42 EST


On Wed, Nov 26, 2025 at 04:17:40PM +0800, Baojun Xu wrote:
> The tas2781-hda supports multi-projects, In some projects,
> GpioInt was dropped due to no IRQ connection.

GpioInt()

> See the example code below:
>
> But in smi_i2c_probe(), smi_spi_probe() (serial-multi-instantiate.c),
> if looking for IRQ by smi_get_irq() fails, it will return an error,
> will not add new device, and cause smi_probe to fail.

smi_probe()

> So need to add an exception case for these situations.
> BTW, this patch will take effect on both I2C and SPI devices.
>
> Device (SPKR)
> {
> Name (_ADR, One)
> Name (_HID, "TXNW2781")
> Method (_CRS, 0, NotSerialized)
> {
> Name (RBUF, ResourceTemplate ()
> {
> I2cSerialBusV2 (0x0038, ...)
> I2cSerialBusV2 (0x0039, ...)
> // GpioInt (Edge, ...) { 0x0000 }
> //"GpioInt (...) {}" was commented out due to no IRQ connection.
> })
> Return (RBUF)
> }
> }

And as Hans said, please fold this into the patch as part of the commit message.

--
With Best Regards,
Andy Shevchenko