Re: [PATCH] dt-bindings: interrupt-controller: renesas,rzv2h-icu: Document RZ/V2N SoC support

[Geert Uytterhoeven]

Hi Prabhakar,

On Tue, 25 Nov 2025 at 22:32, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Document the Interrupt Control Unit (ICU) on the Renesas RZ/V2N SoC,
> which is architecturally identical to the ICU used on the RZ/V2H(P)
> SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzv2h-icu.yaml
> @@ -20,9 +20,14 @@ description:
>
>  properties:
>    compatible:
> -    enum:
> -      - renesas,r9a09g047-icu # RZ/G3E
> -      - renesas,r9a09g057-icu # RZ/V2H(P)
> +    oneOf:
> +      - items:
> +          - enum:
> +              - renesas,r9a09g047-icu # RZ/G3E
> +              - renesas,r9a09g057-icu # RZ/V2H(P)
> +      - items:
> +          - const: renesas,r9a09g056-icu # RZ/V2N
> +          - const: renesas,r9a09g057-icu

Given ICU on RZ/V2H has lots of extra registers compared to RZ/V2N,
I think it would be better to drop the fallback.

>
>    '#interrupt-cells':
>      description: The first cell is the SPI number of the NMI or the

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds