Re: [PATCH v2 2/3] soc: qcom: llcc: Fix usecase id macro alignment

From: Krzysztof Kozlowski

Date: Wed Nov 26 2025 - 03:59:07 EST


On Tue, Nov 25, 2025 at 02:46:23PM +0530, Pankaj Patil wrote:
> Aligned macro values for usecase id along the column length
> -#define LLCC_CAMOFE 71
> -#define LLCC_CAMRTIP 72
> -#define LLCC_CAMSRTIP 73
> -#define LLCC_CAMRTRF 74
> -#define LLCC_CAMSRTRF 75
> -#define LLCC_VIDEO_APV 83
> -#define LLCC_COMPUTE1 87
> -#define LLCC_CPUSS_OPP 88
> -#define LLCC_CPUSSMPAM 89
> -#define LLCC_CAM_IPE_STROV 92
> -#define LLCC_CAM_OFE_STROV 93
> -#define LLCC_CPUSS_HEU 94
> -#define LLCC_MDM_PNG_FIXED 100
> +#define LLCC_CPUSS 1
> +#define LLCC_VIDSC0 2
> +#define LLCC_VIDSC1 3
> +#define LLCC_ROTATOR 4
> +#define LLCC_VOICE 5

This does not look right - you still have here spaces, so nothing fixed.

I don't think this change is useful. You replaced one poor alignment
into another poor alignment, so IMO better not to touch this at all.

Best regards,
Krzysztof