RE: [EXT] Re: [PATCH 5/6] spi: imx: support dynamic burst length for ECSPI DMA mode

[Carlos Song]

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Sent: Wednesday, November 26, 2025 8:23 PM
> To: Carlos Song <carlos.song@xxxxxxx>
> Cc: broonie@xxxxxxxxxx; Frank Li <frank.li@xxxxxxx>; hawnguo@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx;
> linux-spi@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH 5/6] spi: imx: support dynamic burst length for ECSPI
> DMA mode
> 
> On 25.11.2025 18:06:17, Carlos Song wrote:
> >  static int spi_imx_pio_transfer(struct spi_device *spi,
> >  				struct spi_transfer *transfer)
> >  {
> > @@ -1780,9 +2112,14 @@ static int spi_imx_transfer_one(struct
> spi_controller *controller,
> >  	 * transfer, the SPI transfer has already been mapped, so we
> >  	 * have to do the DMA transfer here.
> >  	 */
> > -	if (spi_imx->usedma)
> > -		return spi_imx_dma_transfer(spi_imx, transfer);
> > -
> > +	if (spi_imx->usedma) {
> > +		ret = spi_imx_dma_transfer(spi_imx, transfer);
> > +		if (transfer->error & SPI_TRANS_FAIL_NO_START) {
> > +			spi_imx->usedma = false;
> > +			return spi_imx_pio_transfer(spi, transfer);
> > +		}
> > +		return ret;
> > +	}
> 
> Why do you do this? AFAICS the framework already does this for you see:
> spi_transfer_one_message().
> 
Hi,

In frame work:
				if ((xfer->tx_sg_mapped || xfer->rx_sg_mapped) &&
				    (xfer->error & SPI_TRANS_FAIL_NO_START)) {
					__spi_unmap_msg(ctlr, msg);
					ctlr->fallback = true;
					xfer->error &= ~SPI_TRANS_FAIL_NO_START;
					goto fallback_pio;
				}

It only will help do this for "framework finished DMA map case". But DMA dynamic burst feature is mapped in driver.
So this condition never meet: (xfer->tx_sg_mapped || xfer->rx_sg_mapped) I think..
Carlos

> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |