Re: [PATCH v3 1/9] md: bcache: fix improper use of bi_end_io

From: Coly Li
Date: Mon Dec 01 2025 - 00:45:53 EST


> 2025年11月29日 17:01,zhangshida <starzhangzsd@xxxxxxxxx> 写道:
>
> From: Shida Zhang <zhangshida@xxxxxxxxxx>
>
> Don't call bio->bi_end_io() directly. Use the bio_endio() helper
> function instead, which handles completion more safely and uniformly.
>
> Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Signed-off-by: Shida Zhang <zhangshida@xxxxxxxxxx>
> ---
> drivers/md/bcache/request.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index af345dc6fde..82fdea7dea7 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c

[snipped]

The patch is good. Please modify the patch subject to: bcache: fix improper use of bi_end_io

You may directly send the refined version to linux-bcache mailing list, I will take it.

Thanks.

Coly Li