Re: [PATCH v2] mmc: host: sdhci-msm: Add support for wrapped keys

[Neeraj Soni]

Hi,

On 11/28/2025 11:25 PM, Eric Biggers wrote:
> On Thu, Nov 27, 2025 at 01:00:48PM +0530, Neeraj Soni wrote:
>> Add the wrapped key support for sdhci-msm by implementing the needed
>> methods in struct blk_crypto_ll_ops and setting the appropriate flag in
>> blk_crypto_profile::key_types_supported.
>>
>> ---
>> This is a reworked version of the patchset
>> https://lore.kernel.org/all/20241101031539.13285-1-quic_spuppala@xxxxxxxxxxx/
>> that was sent by Seshu Madhavi Puppala.
>>
>> My changes rebase it to use the custom crypto profile support.
>>
>> Signed-off-by: Neeraj Soni <neeraj.soni@xxxxxxxxxxxxxxxx>
> 
> Your Signed-off-by should go above the scissors line (---).
Thanks for pointing out. I will fix it in next patch.
> 
>> Changes in v2:
>> - Updated commit message for clarity.
>>
>> Changes in v1:
>> - Added initial support for wrapped keys.
>> ---
>>  drivers/mmc/host/sdhci-msm.c | 51 +++++++++++++++++++++++++++++++-----
>>  1 file changed, 45 insertions(+), 6 deletions(-)
> 
> Otherwise the patch looks okay to me.  It lines up with the UFS
> equivalent.  Can you also provide details on how you tested it?
Sure. I tested it on sc7280 (kodiak) eMMC device and will capture the test steps in next patch.
> 
> - Eric
> 
Regards
Neeraj