Re: [PATCH] riscv: pgtable: Cleanup useless VA_USER_XXX definitions
From: Jinjie Ruan
Date: Mon Dec 01 2025 - 04:28:05 EST
On 2025/12/1 8:58, guoren@xxxxxxxxxx wrote:
> From: "Guo Ren (Alibaba DAMO Academy)" <guoren@xxxxxxxxxx>
>
> These marcos are not used after commit b5b4287accd7 ("riscv: mm: Use
> hint address in mmap if available"). Cleanup VA_USER_XXX definitions
> in asm/pgtable.h.
>
> Fixes: b5b4287accd7 ("riscv: mm: Use hint address in mmap if available")
> Signed-off-by: Guo Ren (Alibaba DAMO Academy) <guoren@xxxxxxxxxx>
> ---
> arch/riscv/include/asm/pgtable.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 5a08eb5fe99f..30d1ea93dde3 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -124,10 +124,6 @@
> #ifdef CONFIG_64BIT
> #include <asm/pgtable-64.h>
>
> -#define VA_USER_SV39 (UL(1) << (VA_BITS_SV39 - 1))
> -#define VA_USER_SV48 (UL(1) << (VA_BITS_SV48 - 1))
> -#define VA_USER_SV57 (UL(1) << (VA_BITS_SV57 - 1))
Reviewed-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
> -
> #define MMAP_VA_BITS_64 ((VA_BITS >= VA_BITS_SV48) ? VA_BITS_SV48 : VA_BITS)
> #define MMAP_MIN_VA_BITS_64 (VA_BITS_SV39)
> #define MMAP_VA_BITS (is_compat_task() ? VA_BITS_SV32 : MMAP_VA_BITS_64)