RE: [PATCH v3 3/8] pwm: rzg2l-gpt: Add prescale_pow_of_two_mult_factor variable to struct rzg2l_gpt_info
From: Biju Das
Date: Mon Dec 01 2025 - 05:57:27 EST
Hello Uwe,
> -----Original Message-----
> From: Uwe Kleine-König <ukleinek@xxxxxxxxxx>
> Sent: 30 November 2025 08:29
> Subject: Re: [PATCH v3 3/8] pwm: rzg2l-gpt: Add prescale_pow_of_two_mult_factor variable to struct
> rzg2l_gpt_info
>
> Hello Biju,
>
> On Tue, Sep 23, 2025 at 03:45:07PM +0100, Biju wrote:
> > @@ -91,6 +91,7 @@
> >
> > struct rzg2l_gpt_info {
> > u32 gtcr_tpcs_mask;
> > + u8 prescale_pow_of_two_mult_factor;
>
> To reduce the line length a bit I suggest to call this just "prescale_mult". That this is (up to
> now :-) a power of two isn't relevant enough to be mentioned in the name.
>
> Otherwise looks fine.
OK, will change it to "prescale_mult".
Cheers,
Biju