Re: [PATCH v2 0/1] mcb: Add modpost support for processing MODULE_DEVICE_TABLE
From: Andy Shevchenko
Date: Mon Dec 01 2025 - 13:05:00 EST
On Mon, Dec 01, 2025 at 05:07:19PM +0100, Jose Javier Rodriguez Barbarin wrote:
> During the process of update of one of the device drivers that are part of
> mcb bus (gpio-menz127.c), Krzysztof from GPIO subsystem asked me
> why I was adding new MODULE_ALIAS when I also added the same new
> information on MODULE_DEVICE_TABLE.
>
> You can find the messages here:
>
> https://lore.kernel.org/linux-gpio/80a20b13-7c6a-4483-9741-568424f957ef@xxxxxxxxxx/
>
> After a deeper analysis, I came across that the mcb_table_id defined inside
> MODULE_DEVICE_TABLE on all device drivers was being ignored as modpost was
> not processing the mcb MODULE_DEVICE_TABLE entries. For this reason, former
> contributors were using MODULE_ALIAS for enabling mcb to autoload the
> device drivers.
>
> My proposal with these changes is to complete the mcb bus by adding
> modpost support for processing mcb MODULE_DEVICE_TABLE.
>
> Once this patch is merged, I will send patches one by one for removing
> MODULE_ALIAS from all device drivers as they are no longer needed
> (as Andy Shevchenko suggested in v1 review).
Not sure if we need a cover letter for a single change, but yes, this
what I think the best approach and code wise it's fine to me:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
(but we still need a Fixes tag I assume).
--
With Best Regards,
Andy Shevchenko