Re: [GIT PULL 16/17 for v6.19] vfs fd prepare

From: Sean Christopherson
Date: Mon Dec 01 2025 - 13:41:16 EST


On Mon, Dec 01, 2025, Al Viro wrote:
> On Fri, Nov 28, 2025 at 05:48:27PM +0100, Christian Brauner wrote:
> > Hey Linus,
> >
> > /* Summary */
> > Note: This work came late in the cycle but the series is quite nice and
> > worth doing. It removes roughly double the code that it adds and
> > eliminates a lot of convoluted cleanup logic across the kernel.
> >
> > An alternative pull request (vfs-6.19-rc1.fd_prepare.fs) is available
> > that contains only the more simple filesystem-focused conversions in
> > case you'd like to pull something more conservative.
> >
> > Note this branch also contains two reverts for the KVM FD_PREPARE()
> > conversions as the KVM maintainers have indicated they would like to
> > take those changes through the KVM tree in the next cycle. Also gets rid
> > of a merge conflict. I chose a revert to not rebase the branch
> > unnecessarily so close to the merge window.
>
> Frankly, that hadn't gotten anywhere near enough exposure in -next and
> it's far too large and invasive.

+1. Saying that I want to take the KVM changes through the KVM tree is
technically true, but glosses over why I objected (or even noticed) in the first
place.

https://lore.kernel.org/all/20251125155455.31c53cf9@xxxxxxxxxxxxxxxx