Re: [PATCH v2 2/3] unwind_user/fp: Use dummies instead of ifdef

From: Ingo Molnar
Date: Mon Dec 01 2025 - 15:30:45 EST



* Jens Remus <jremus@xxxxxxxxxxxxx> wrote:

> -#ifndef ARCH_INIT_USER_FP_FRAME
> - #define ARCH_INIT_USER_FP_FRAME
> +#ifndef CONFIG_HAVE_UNWIND_USER_FP
> +
> +#define ARCH_INIT_USER_FP_FRAME(ws)
> +
> +#endif /* !CONFIG_HAVE_UNWIND_USER_FP */

Just a nit, there's no need for the closing /* !.. */
comment for such a short CPP block - just like it's
done in the next couple of lines:

> +#ifndef ARCH_INIT_USER_FP_ENTRY_FRAME
> +#define ARCH_INIT_USER_FP_ENTRY_FRAME(ws)
> +#endif

Thanks,

Ingo