Re: [PATCH v2 01/11] ntfsplus: in-memory, on-disk structures and headers

From: Namjae Jeon
Date: Mon Dec 01 2025 - 16:54:49 EST


On Mon, Dec 1, 2025 at 8:46 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Mon, Dec 01, 2025 at 03:22:43AM -0800, Christoph Hellwig wrote:
> > On Mon, Dec 01, 2025 at 07:13:49PM +0900, Namjae Jeon wrote:
> > > CPU intensive spinning only occurs if signals are delivered extremely
> > > frequently...
> > > Are there any ways to improve this EINTR handling?
> > > Thanks!
> >
> > Have an option to not abort when fatal signals are pending?
>
> I'd rather not add a sixth argument to do_read_cache_folio().
>
> And I'm not sure the right question is being asked here. Storage can
> disappear at any moment -- somebody unplugs the USB device, the NBD
> device that's hosting the filesystem experiences a network outage, etc.
>
> So every filesystem _should_ handle fatal signals gracefully. The task
> must die, even if it's in the middle of reading metadata. I know that's
> not always the easiest thing to do, but it is the right thing to do.
Okay, I will look into ways to improve it. Thank you for your feedback.