RE: [PATCH 1/2] arm64: dts: mediatek: mt8189: Add thermal controller node

[Hanchien Lin (林翰謙)]

Hi Conor,

Thanks for your feedback. Sorry for overlooking this part. I will update the patch subject and include the missing content in v3.

Best regards,
Hanchien Lin.

-----Original Message-----
From: Conor Dooley <conor@xxxxxxxxxx> 
Sent: Tuesday, November 11, 2025 2:45 AM
To: Hanchien Lin (林翰謙) <Hanchien.Lin@xxxxxxxxxxxx>
Cc: Rafael J . Wysocki <rafael@xxxxxxxxxx>; Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>; Zhang Rui <rui.zhang@xxxxxxxxx>; Lukasz Luba <lukasz.luba@xxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>; Matthias Brugger <matthias.bgg@xxxxxxxxx>; AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>; Balsam CHIHI <bchihi@xxxxxxxxxxxx>; linux-pm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@xxxxxxxxxxxx>; Raymond Sun (孫俊斌) <Raymond.Sun@xxxxxxxxxxxx>; Irving-CH Lin (林建弘) <Irving-CH.Lin@xxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] arm64: dts: mediatek: mt8189: Add thermal controller node

On Mon, Nov 10, 2025 at 05:40:38PM +0800, Hanchien Lin wrote:
> Add device tree node for the thermal controller on MediaTek MT8189 SoC.

$subject is incorrect for a binding change.
pw-bot: changes-requested

> 
> Signed-off-by: Hanchien Lin <hanchien.lin@xxxxxxxxxxxx>
> ---
>  .../thermal/mediatek,lvts-thermal.yaml        | 27 +++++++++++++++++--
>  .../thermal/mediatek,lvts-thermal.h           | 20 ++++++++++++++
>  2 files changed, 45 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> index 0259cd3ce9c5..0f7fd69f5fdf 100644
> --- a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> @@ -22,6 +22,8 @@ properties:
>        - mediatek,mt8186-lvts
>        - mediatek,mt8188-lvts-ap
>        - mediatek,mt8188-lvts-mcu
> +      - mediatek,mt8189-lvts-ap
> +      - mediatek,mt8189-lvts-mcu
>        - mediatek,mt8192-lvts-ap
>        - mediatek,mt8192-lvts-mcu
>        - mediatek,mt8195-lvts-ap
> @@ -58,6 +60,21 @@ properties:
>  allOf:
>    - $ref: thermal-sensor.yaml#
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt8189-lvts-ap
> +              - mediatek,mt8189-lvts-mcu
> +    then:
> +      properties:
> +        nvmem-cells:
> +          minItems: 2
> +
> +        nvmem-cell-names:
> +          minItems: 2
> +
>    - if:
>        properties:
>          compatible:
> @@ -75,6 +92,10 @@ allOf:
>          nvmem-cell-names:
>            maxItems: 1
>  
> +      required:
> +        - clocks
> +        - resets
> +
>    - if:
>        properties:
>          compatible:
> @@ -91,12 +112,14 @@ allOf:
>          nvmem-cell-names:
>            minItems: 2
>  
> +      required:
> +        - clocks
> +        - resets
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
> -  - clocks
> -  - resets
>    - nvmem-cells
>    - nvmem-cell-names
>  
> diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/dt-bindings/thermal/mediatek,lvts-thermal.h
> index ddc7302a510a..6c9103dfdc2d 100644
> --- a/include/dt-bindings/thermal/mediatek,lvts-thermal.h
> +++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h
> @@ -42,6 +42,26 @@
>  #define MT8188_AP_CAM1		6
>  #define MT8188_AP_CAM2		7
>  
> +#define MT8189_MCU_BIG_CPU1     0
> +#define MT8189_MCU_BIG_CPU2     1
> +#define MT8189_MCU_BIG_CPU3     2
> +#define MT8189_MCU_BIG_CPU4     3
> +#define MT8189_MCU_LITTLE_CPU1  4
> +#define MT8189_MCU_LITTLE_CPU2  5
> +#define MT8189_MCU_LITTLE_CPU3  6
> +#define MT8189_MCU_LITTLE_CPU4  7
> +#define MT8189_MCU_LITTLE_CPU5  8
> +#define MT8189_MCU_LITTLE_CPU6  9
> +#define MT8189_MCU_LITTLE_CPU7  10
> +#define MT8189_MCU_LITTLE_CPU8  11
> +
> +#define MT8189_AP_SOC1          12
> +#define MT8189_AP_SOC2          13
> +#define MT8189_AP_SOC3          14
> +#define MT8189_AP_APU           15
> +#define MT8189_AP_GPU1          16
> +#define MT8189_AP_GPU2          17
> +
>  #define MT8195_MCU_BIG_CPU0     0
>  #define MT8195_MCU_BIG_CPU1     1
>  #define MT8195_MCU_BIG_CPU2     2
> -- 
> 2.45.2
>