Re: [PATCH v5 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali

[Krzysztof Kozlowski]

On 02/12/2025 07:06, Kumari Pallavi wrote:
> Kaanapali introduces changes in DSP IOVA layout and CDSP DMA addressing
> that differ from previous SoCs. The SID field moves within the physical
> address, and CDSP now supports a wider DMA range, requiring updated
> sid_pos and DMA mask handling in the driver.
> To apply these changes only on Kaanapali, add a SoC-specific compatible
> string "qcom,kaanapali-fastrpc". Older DTs using "qcom,fastrpc" remain
> valid.

Drop last two sentences, redundant. Patch contents tell that.

> 
> Signed-off-by: Kumari Pallavi <kumari.pallavi@xxxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

You did not test the v4, so is this one tested?

> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> index 3f6199fc9ae6..8bf7d4d83c8b 100644
> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
> @@ -18,7 +18,13 @@ description: |
>  
>  properties:
>    compatible:
> -    const: qcom,fastrpc
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,kaanapali-fastrpc
> +          - const: qcom,fastrpc
> +      - items:

I asked last time to drop the unnecessary items. Wasn't here before.

> +          - const: qcom,fastrpc
>  
>    label:
>      enum:


Best regards,
Krzysztof