[PATCH] counter: 104-quad-8: Fix incorrect return value in IRQ handler
From: Haotian Zhang
Date: Tue Dec 02 2025 - 03:41:01 EST
quad8_irq_handler() should return irqreturn_t enum values, but it
directly returns negative errno codes from regmap operations on error.
Return IRQ_NONE instead of raw errno codes on regmap operation failures.
Fixes: 98ffe0252911 ("counter: 104-quad-8: Migrate to the regmap API")
Signed-off-by: Haotian Zhang <vulab@xxxxxxxxxxx>
---
drivers/counter/104-quad-8.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index ce81fc4e1ae7..17f4da6c24af 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -1201,7 +1201,7 @@ static irqreturn_t quad8_irq_handler(int irq, void *private)
ret = regmap_read(priv->map, QUAD8_INTERRUPT_STATUS, &status);
if (ret)
- return ret;
+ return IRQ_NONE;
if (!status)
return IRQ_NONE;
@@ -1233,7 +1233,7 @@ static irqreturn_t quad8_irq_handler(int irq, void *private)
ret = regmap_write(priv->map, QUAD8_CHANNEL_OPERATION, CLEAR_PENDING_INTERRUPTS);
if (ret)
- return ret;
+ return IRQ_NONE;
return IRQ_HANDLED;
}
--
2.50.1.windows.1