Re: [PATCH] usb: linux/usb.h: Correct the description of the usb_device_driver member

From: Greg KH
Date: Tue Dec 02 2025 - 04:01:06 EST


On Tue, Dec 02, 2025 at 02:59:17PM +0800, Yi Cong wrote:
> On Mon, 1 Dec 2025 10:14:04 -0500, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Mon, Dec 01, 2025 at 04:53:09PM +0800, Yi Cong wrote:
> > > From: Yi Cong <yicong@xxxxxxxxxx>
> > >
> > > In the current kernel USB device driver code, only the name field is
> > > required to be provided; all other fields are optional.
> > > Use the command grep -rnw "struct usb_device_driver" to inspect
> > > how specific drivers are declared.
> >
> > That last sentence should not be part of the patch description; it
> > doesn't explain the patch's purpose or what the patch does. (It's not
> > even correct, because the grep output doesn't show how the specific
> > drivers are declared. It mainly shows the filenames and line numbers
> > where the declarations start.)
> >
>
> Thank you for the reply!
> Do I need to update the commit message and send a new version of the patch?

Yes please.