Re: [GIT PULL 17/17 for v6.19] vfs fd prepare minimal

From: Christian Brauner
Date: Tue Dec 02 2025 - 04:44:46 EST


On Mon, Dec 01, 2025 at 05:35:39PM -0800, Linus Torvalds wrote:
> On Fri, 28 Nov 2025 at 08:51, Christian Brauner <brauner@xxxxxxxxxx> wrote:
> >
> > This is an alternative pull request for the FD_{ADD,PREPARE}() work containing
> > only parts of the conversion.
>
> Ok, I'm nto super happy with how thsi all looks, partly because
> there's been a lot of conflicts. I don't t hink this was well done,
> with multiple different areas getting cleaned up in the same release.
>
> I considered leaving some stuff entirely for the next go-around, but
> I've taken it all, although I only took this smaller version of the
> FD_ADD().
>
> Not because I think anything was particularly bad, but simply because
> I feel it was too much churn for one release. This is all old code
> that didn't need to be changed all at once.
>
> Please don't do this again. We're not in that kind of a hurry, and
> hurried cleanups aren't great.

I understand. I'm sorry if I rushed this. I was excited about the series
and I thought I'd leave the decision to you. I'll be more conservative
next time.