Re: [PATCH 4/6] sched/fair: Rename avg_vruntime() to cfs_avg_vruntime()
From: Peter Zijlstra
Date: Tue Dec 02 2025 - 05:24:58 EST
On Mon, Dec 01, 2025 at 07:46:45AM +0100, Ingo Molnar wrote:
> Since the unit of the ->avg_vruntime field isn't actually
> the same thing as the avg_vruntime() result, reduce confusion
> and rename the latter to the common cfs_*() nomenclature of
> visible global functions of the fair scheduler.
But you're going to rename both those fields into sum_weight and
sum_w_vruntime freeing up the avg_vruntime name and clearing up the
above confusion.
So why then still rename the thing? The result of the function really is
the (weighted) average of the vruntime, so the naming isn't confusing
or bad (unlike the variables it uses, which are pretty badly named).