Re: [PATCH net 1/2] net/mlx5: make enable_mpesw idempotent
From: Simon Horman
Date: Tue Dec 02 2025 - 10:24:10 EST
On Mon, Dec 01, 2025 at 05:13:27PM +0200, Tariq Toukan wrote:
> From: Moshe Shemesh <moshe@xxxxxxxxxx>
>
> The enable_mpesw() function returns -EINVAL if ldev->mode is not
> MLX5_LAG_MODE_NONE. This means attempting to enable MPESW mode when it's
> already enabled will fail. In contrast, disable_mpesw() properly checks
> if the mode is MLX5_LAG_MODE_MPESW before proceeding, making it
> naturally idempotent and safe to call multiple times.
>
> Fix enable_mpesw() to return success if mpesw is already enabled.
>
> Fixes: a32327a3a02c ("net/mlx5: Lag, Control MultiPort E-Switch single FDB mode")
> Signed-off-by: Moshe Shemesh <moshe@xxxxxxxxxx>
> Reviewed-by: Shay Drori <shayd@xxxxxxxxxx>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>