Re: [PATCH] fbdev/pxafb: Fix multiple clamped values in pxafb_adjust_timing

[Helge Deller]

On 12/2/25 19:36, Thorsten Blum wrote:
> On 2. Dec 2025, at 19:28, Helge Deller wrote:
> > On 12/2/25 19:15, Thorsten Blum wrote:
> > > The variables were never clamped because the return value of clamp_val()
> > > was not used. Fix this by assigning the clamped values, and use clamp()
> > > instead of clamp_val().
> > > Cc: stable@xxxxxxxxxxxxxxx
> > > Fixes: 3f16ff608a75 ("[ARM] pxafb: cleanup of the timing checking code")
> > > Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> > > ---
> > >   drivers/video/fbdev/pxafb.c | 12 ++++++------
> > >   1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > Thanks for the patch!
> > It looks good, so I'll include it in the fbdev tree.
> > Out of curiosity:
> > How did you notice? Do you actually have the hardware and tested it?
>
> I only compile-tested it.
>
> I stumbled upon another driver with the same bug and then used grep to
> search for other instances and found about 6 or 7, including this one.

Ok. But this then means, maybe the clamping isn't needed (since nobody complained),
or that nobody noticed because nobody uses the driver any longer.
Anyway, I believe the patch is correct, so I leave it in.

Thank you!
Helge