Re: [PATCH v2 4/4] ptp: ptp_vmclock: Add device tree support

From: David Woodhouse
Date: Tue Dec 02 2025 - 18:43:53 EST


On Tue, 2025-12-02 at 20:12 +0000, Chalios, Babis wrote:
> From: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> Add device tree support to the ptp_vmclock driver, allowing it to probe
> via device tree in addition to ACPI.
>
> Handle optional interrupt for clock disruption notifications, mirroring
> the ACPI notification behavior.
>
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
> Signed-off-by: Babis Chalios <bchalios@xxxxxxxxx>
> ---
>  drivers/ptp/ptp_vmclock.c | 69 +++++++++++++++++++++++++++++++++++----
>  1 file changed, 63 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c
> index 49a17435bd35..1af50e06e212 100644
> --- a/drivers/ptp/ptp_vmclock.c
> +++ b/drivers/ptp/ptp_vmclock.c
> @@ -18,6 +18,7 @@
>  #include <linux/miscdevice.h>
>  #include <linux/mm.h>
>  #include <linux/module.h>
> +#include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>

Needs <linux/interrupt.h> (a few lines up) too.

...
> +static int vmclock_probe_dt(struct device *dev, struct vmclock_state *st)
> +{
> + struct platform_device *pdev = to_platform_device(dev);
> + struct resource *res;
> + int irq, ret;

Those are unused now.

Attachment: smime.p7s
Description: S/MIME cryptographic signature