Re: [PATCH 1/1] usb: mtk-xhci: add support remote wakeup of mt8189

[AngeloGioacchino Del Regno]

Il 03/12/25 02:34, Mingjin Ge ha scritto:
> Add remote wakeup configuration for the mt8189 in xhci-mtk driver.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> Signed-off-by: Mingjin Ge <mingjin.ge@xxxxxxxxxxxx>

This is not the first time that I say this - and probably not the last one.

Please, stop hiding hardware - the MT8189 SoC has their XHCI controllers behind
MTU3 controllers.

Please add the wakeup configuration controls to MTU3.

I didn't check the datasheet and going by memory here, so here's what to do:
 - If there is no standalone XHCI controller (all of them have a MTU3 parent)
   *do not* add the UWK here in XHCI-MTK, but add it in MTU3 only;
 - If there is at least one standalone XHCI controller (which has no MTU3 parent)
   add UWK *both* in XHCI-MTK *and* in MTU3.

Regards,
Angelo

> ---
>   drivers/usb/host/xhci-mtk.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 8da05e9dfa28..134a46907db5 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -96,6 +96,10 @@
>   #define WC0_IS_P	BIT(12)	/* polarity */
>   #define WC0_IS_EN	BIT(6)
>   
> +/* mt8189*/
> +#define PERI_WK_CTRL0_8189	0x0
> +#define WC0_IS_EN_P_89		BIT(18)
> +
>   /* mt8192 */
>   #define WC0_SSUSB0_CDEN		BIT(6)
>   #define WC0_IS_SPM_EN		BIT(1)
> @@ -140,6 +144,7 @@ enum ssusb_uwk_vers {
>   	SSUSB_UWK_V1_7,		/* mt8196 IP0 */
>   	SSUSB_UWK_V1_8,		/* mt8196 IP1 */
>   	SSUSB_UWK_V1_9,		/* mt8196 IP2 */
> +	SSUSB_UWK_V1_10,	/* mt8189 IP all */
>   };
>   
>   /*
> @@ -407,6 +412,11 @@ static void usb_wakeup_ip_sleep_set(struct xhci_hcd_mtk *mtk, bool enable)
>   		msk = WC1_IS_EN_P2_96;
>   		val = enable ? msk : 0;
>   		break;
> +	case SSUSB_UWK_V1_10:
> +		reg = mtk->uwk_reg_base + PERI_WK_CTRL0_8189;
> +		msk = WC0_IS_EN_P_89;
> +		val = enable ? msk : 0;
> +		break;
>   	case SSUSB_UWK_V2:
>   		reg = mtk->uwk_reg_base + PERI_SSUSB_SPM_CTRL;
>   		msk = SSC_IP_SLEEP_EN | SSC_SPM_INT_EN;