Re: [PATCH v2 1/1] scsi: core: Fix error handler encryption support

[Hannes Reinecke]

On 12/3/25 08:38, Christoph Hellwig wrote:
> On Wed, Dec 03, 2025 at 07:33:08AM +0000, Po-Wen Kao wrote:
> > From: Brian Kao <powenkao@xxxxxxxxxx>
> >
> > Some low-level drivers (LLD) access block layer crypto fields, such as
> > rq->crypt_keyslot and rq->crypt_ctx within `struct request`, to
> > configure hardware for inline encryption.
>
> So don't do that except for commands that can actually be encrypted,
> i.e. those that have non-zero payload size.  I think you really want
> to fix this in the driver.
>
> And we really need to stop passing scsi_cmnds to the error handler.
>
> Hannes, any chance you could send another batch of your decades old
> series?
There had been an intersection with the reserved command stuff, but
now that Bart has dusted things off there I guess I should give it
another go.

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxxx                               +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich