Re: [PATCH v1 31/31] serial: 8250_mxpcie: add RS485-2W auto-adjust sysfs control

[Andy Shevchenko]

On Wed, Dec 3, 2025 at 4:56 AM Crescent Hsieh <crescentcy.hsieh@xxxxxxxx> wrote:
> On Mon, Dec 01, 2025 at 04:45:58AM +0200, Andy Shevchenko wrote:
> > On Sun, Nov 30, 2025 at 12:46 PM Crescent Hsieh
> > <crescentcy.hsieh@xxxxxxxx> wrote:

...

> > I'm not going to review this, the patch series is already quite big. I
> > suggest you to start from the small things in a different series E.g.,
> > the first series is just converting MOXA from custom to 8250-based
> > (assuming all features are kept working while ABI is being broken,

In case you are wondering what I was talking about in the above, I
meant move from /dev/ttyMIxx to /dev/ttySxx. This will break all the
current kernel command lines and hence setups with the explicit
mention of the /dev/ttyMIxx, such as console=.  There might be other
breakages, but I leave it up to you to research and come up with a
solution.

> > which has to be explained in the commit message(s) / cover letter of
> > that series), the second one is about splitting 8250_pci to the other
> > Moxa case. When this is done, we may go forward with the additional
> > features.

> Thanks a lot for spending so much time reviewing this large patch set.
> I appreciate the detailed feedback.

You're welcome!

> I will split this big patch series into smaller and more focused series
> to make it easier to review.
>
> Thanks again for your guidance.

Any time!

-- 
With Best Regards,
Andy Shevchenko