Re: [PATCH v4 8/8] arm64: dts: qcom: Add support for Pixel 3 and Pixel 3 XL

[David Heidelberg]

On 06/12/2025 17:56, Bjorn Andersson wrote:
> On Tue, Nov 25, 2025 at 09:29:43PM +0100, David Heidelberg via B4 Relay wrote:
> > From: David Heidelberg <david@xxxxxxx>
> >
> > This adds initial device tree support for the following phones:
> >
> >   - Google Pixel 3 (blueline)
> >   - Google Pixel 3 XL (crosshatch)
> >
> > Both phone boards use the same identifiers and differ only slightly
> > in their connected peripherals.
> >
> > Supported functionality includes:
> >   - Debug UART
> >   - UFS
> >   - USB-C (peripheral mode)
> >   - Display (Pixel 3 only, and the driver needs improvements)
> >   - GPU
> >   - Bluetooth
> >   - Wi-Fi
> >
> > The rmtfs region is allocated using UIO, making it technically "dynamic."
> >
> > Its address and size can be read from sysfs:
> >
> > $ cat /sys/class/uio/uio0/name
> > /sys/class/uio/uio0/maps/map0/addr
> > 0x00000000f2701000
> >
> > $ cat /sys/class/uio/uio0/maps/map0/size
> > 0x0000000000200000
> >
> > Like the OnePlus 6, the Pixel 3 requires 1 kB of reserved memory on either
> > side of the rmtfs region to work around an XPU bug that would otherwise
> > cause erroneous violations when accessing the rmtfs_mem region.
> >
> > Co-developed-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
> > Signed-off-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
> > Co-developed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>
> Did I really co-author this patch? Perhaps I contributed parts to it?
> Perhaps I've just forgotten?

The patch and it's parts I used contained your S-off-by, so I added 
Co-developed-by as I assumed parts of it was written by you.

That's hard about seeing patches downstream, as the history is not so clear.

> Either way, I don't think I can say that I certify origin of the whole
> patch.

Should I drop your the Signed-off-by then (and eventually all people who 
didn't worked on the series I sent to upstream)?
> Any parts that I did contribute, would have met the criteria, so you're
> free to use those.

Thanks!

David

> Regards,
> Bjorn
>
> > Co-developed-by: Casey Connolly <casey@xxxxxxxxxxxxx>
> > Signed-off-by: Casey Connolly <casey@xxxxxxxxxxxxx>
> > Co-developed-by: Joel Selvaraj <foss@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Joel Selvaraj <foss@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> > Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> > Co-developed-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > Signed-off-by: David Heidelberg <david@xxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/Makefile                  |   2 +
> >   .../arm64/boot/dts/qcom/sdm845-google-blueline.dts |  77 +++
> >   arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 528 +++++++++++++++++++++
> >   .../boot/dts/qcom/sdm845-google-crosshatch.dts     |  28 ++
> >   4 files changed, 635 insertions(+)